gtk/a11y: Use allocated events
authorCarlos Garnacho <carlosg@gnome.org>
Wed, 25 Oct 2017 10:26:32 +0000 (12:26 +0200)
committerCarlos Garnacho <carlosg@gnome.org>
Wed, 13 Dec 2017 23:58:32 +0000 (00:58 +0100)
Using stack allocated GdkEvent will not be ok when they become
objects.

gtk/a11y/gtkentryaccessible.c

index 282f305e63cd08302b12c5d9acb412953cccc145..1061774742ee2221a9d8faf85b809e06718fd0f0 100644 (file)
@@ -221,7 +221,7 @@ gtk_entry_icon_accessible_do_action (AtkAction *action,
   GtkEntryIconAccessible *icon = (GtkEntryIconAccessible *)action;
   GtkWidget *widget;
   GtkEntry *gtk_entry;
-  GdkEvent event;
+  GdkEvent *event;
   GdkRectangle icon_area;
 
   widget = gtk_accessible_get_widget (GTK_ACCESSIBLE (icon->entry));
@@ -241,16 +241,17 @@ gtk_entry_icon_accessible_do_action (AtkAction *action,
     return FALSE;
 
   gtk_entry_get_icon_area (gtk_entry, icon->pos, &icon_area);
-  memset (&event, 0, sizeof (event));
-  event.any.type = GDK_BUTTON_PRESS;
-  event.any.window = gtk_widget_get_window (widget);
-  event.button.button = 1;
-  event.any.send_event = TRUE;
-  event.button.time = GDK_CURRENT_TIME;
-  event.button.x = icon_area.x;
-  event.button.y = icon_area.y;
-
-  g_signal_emit_by_name (widget, "icon-press", 0, icon->pos, &event);
+
+  event = gdk_event_new (GDK_BUTTON_PRESS);
+  event->any.window = g_object_ref (gtk_widget_get_window (widget));
+  event->button.button = 1;
+  event->any.send_event = TRUE;
+  event->button.time = GDK_CURRENT_TIME;
+  event->button.x = icon_area.x;
+  event->button.y = icon_area.y;
+
+  g_signal_emit_by_name (widget, "icon-press", 0, icon->pos, event);
+  gdk_event_free (event);
   return TRUE;
 }